New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harden some problematic release tests. #20155
Harden some problematic release tests. #20155
Conversation
Ignore failure to remove module in AfterAll. Handle the case where get-volume does not return a volume. Add missing back-quote to test checking whether psmodulepath is obscured appropriately.
test/powershell/Modules/Microsoft.PowerShell.Management/Get-ChildItem.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Management/Get-ChildItem.Tests.ps1
Outdated
Show resolved
Hide resolved
@@ -73,6 +73,7 @@ try | |||
try | |||
{ | |||
Invoke-LanguageModeTestingSupportCmdlet -SetLockdownMode | |||
Start-Sleep -Seconds 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this one missed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep
pushed a fix
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Ignore failure to remove module in AfterAll.
Handle the case where get-volume does not return a volume. Add missing back-quote to test checking whether psmodulepath is obscured appropriately.
PR Summary
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).