New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change New-FileCatalog -CatalogVersion default to 2 #20428
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
@daxian-dbw think I could get the CI to run again? The test failure isn't related to this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we a test for default value?
@iSazonov the existing test using the default value was updated to check the algorithm is now using SHA256 instead SHA1. |
@iSazonov do you have access to kick off CI again? |
Macos Test-Connection test was restarted. |
📣 Hey @ThomasNieto, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://forms.office.com/r/P926k48jRJ |
The breaking change was reviewed and approved by the Security WG (see the corresponding issue). |
PR Summary
Updates the default parameter value from 1 to 2.
PR Context
Resolves #19131
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).