New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rendering of DisplayRoot for network PSDrive #20793
Conversation
@SteveL-MSFT Now we remove the workaround with |
67b4fe1
to
69f69f0
Compare
src/System.Management.Automation/engine/Interop/Windows/WNetGetConnection.cs
Outdated
Show resolved
Hide resolved
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
PR Summary
As part of some refactoring work to use spans, it appears that the code to get the DisplayRoot simply used
ToString()
on the ushort buffer. However,ToString()
only works on a span of chars, so this resulted in returning the type and size instead of the contents. Fix is to get a Unicode string from the ushort buffer as bytes.PR Context
Fix #19903
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).