New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies for v7.4.1 #20871
Update dependencies for v7.4.1 #20871
Conversation
@@ -16,6 +16,7 @@ | |||
|
|||
<ItemGroup> | |||
<!-- This section is to force the version of non-direct dependencies --> | |||
<PackageReference Include="Microsoft.Extensions.ObjectPool" Version="5.0.17" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ Transitive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question here, I wonder if this needs to be explicitly specified.
@@ -33,6 +34,7 @@ | |||
<PackageReference Include="System.ServiceModel.Primitives" Version="4.10.3" /> | |||
<PackageReference Include="System.ServiceModel.Security" Version="4.10.3" /> | |||
<PackageReference Include="System.Private.ServiceModel" Version="4.10.3" /> | |||
<PackageReference Include="System.Web.Services.Description" Version="4.10.3" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ Transitive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" PrivateAssets="all" /> | ||
<!-- This section is to force the version of non-direct dependencies --> | ||
<PackageReference Include="Microsoft.NETCore.Platforms" Version="1.1.2" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ Transitive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
<PackageReference Include="JsonSchema.Net" Version="5.2.6" /> | ||
<PackageReference Include="JsonSchema.Net" Version="5.2.7" /> | ||
<!-- This section is to force the version of non-direct dependencies --> | ||
<PackageReference Include="Json.More.Net" Version="1.9.2" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ Transitive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we didn't add this transitive package in the GA release, why do we need to add it now?
<PackageReference Include="JsonSchema.Net" Version="5.2.6" /> | ||
<PackageReference Include="JsonSchema.Net" Version="5.2.7" /> | ||
<!-- This section is to force the version of non-direct dependencies --> | ||
<PackageReference Include="Json.More.Net" Version="1.9.2" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we didn't add this transitive package in the GA release, why do we need to add it now?
@@ -16,6 +16,7 @@ | |||
|
|||
<ItemGroup> | |||
<!-- This section is to force the version of non-direct dependencies --> | |||
<PackageReference Include="Microsoft.Extensions.ObjectPool" Version="5.0.17" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question here, I wonder if this needs to be explicitly specified.
@@ -33,6 +34,7 @@ | |||
<PackageReference Include="System.ServiceModel.Primitives" Version="4.10.3" /> | |||
<PackageReference Include="System.ServiceModel.Security" Version="4.10.3" /> | |||
<PackageReference Include="System.Private.ServiceModel" Version="4.10.3" /> | |||
<PackageReference Include="System.Web.Services.Description" Version="4.10.3" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" PrivateAssets="all" /> | ||
<!-- This section is to force the version of non-direct dependencies --> | ||
<PackageReference Include="Microsoft.NETCore.Platforms" Version="1.1.2" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
test/xUnit/xUnit.tests.csproj
Outdated
@@ -23,9 +23,12 @@ | |||
</ItemGroup> | |||
|
|||
<ItemGroup> | |||
<PackageReference Include="xunit" Version="2.5.0" /> | |||
<PackageReference Include="xunit" Version="2.5.3" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving to 2.5.3 causes xUnit test to fail. I didn't look closely and thus not sure why.
test/xUnit/xUnit.tests.csproj
Outdated
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | ||
<PrivateAssets>all</PrivateAssets> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The markdown link test failure is not related to the changes in this PR. |
PR Summary
Updating dependencies for release v7.4.1
PR Context
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).