Revert "Adjust PUT method behavior to POST one for default content type in WebCmdlets"

[SteveL-MSFT]

Reverts #19152

This has been reported as a regression for the cmdlet working against Azure Blob Storage. The added content-type with PUT is causing the request to be rejected. It seems that curl does add the content-type for POST, but not for PUT, so we should do the same with the cmdlets.

[pull-request-quantifier-deprecated]

This PR has 22 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

---

Quantification details

Label      : Extra Small
Size       : +7 -15
Percentile : 8.8%

Total files changed: 2

Change summary by file extension:
.cs : +1 -1
.ps1 : +6 -14

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

• Fast and predictable releases to production:
  • Optimal size changes are more likely to be reviewed faster with fewer
    iterations.
  • Similarity in low PR complexity drives similar review times.
• Review quality is likely higher as complexity is lower:
  • Bugs are more likely to be detected.
  • Code inconsistencies are more likely to be detected.
• Knowledge sharing is improved within the participants:
  • Small portions can be assimilated better.
• Better engineering practices are exercised:
  • Solving big problems by dividing them in well contained, smaller problems.
  • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

• Use the PullRequestQuantifier to quantify your PR accurately
  • Create a context profile for your repo using the context generator
  • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
  • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
  • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
• Change your engineering behaviors
  • For PRs that fall outside of the desired spectrum, review the details and check if:
    • Your PR could be split in smaller, self-contained PRs instead
    • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

• One line was added: +1 -0
• One line was deleted: +0 -1
• One line was modified: +1 -1 (git diff doesn't know about modified, it will
  interpret that line like one addition plus one deletion)
• Change percentiles: Change characteristics (addition, deletion, modification)
  of this PR in relation to all other PRs within the repository.

---

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

[iSazonov]

It seems that curl does add the content-type for POST, but not for PUT,

There was another comment from @CarloToso #16318 (comment)

Curl doesn't add any Content-Type for POST and PUT

Original request from #16318 was that all method should work identically.

Single difference from POST and PUT is #16318 (comment)

The difference between POST and PUT is that PUT requests are idempotent. That is, calling the same PUT request multiple times will always produce the same result. In contrast, calling a POST request repeatedly have side effects of creating the same resource multiple times.

Adding the Content Type to the PUT was an attempt to avoid regression in PowerShell scenarios compared to removing it from the POST.

If we still see regression, then we return to the original question of how to make methods with one behavior - remove ContentType from POST as in curl? And do we need to leave this default value there for hashtables as specific PowerShell scenario?

---

This change was made almost a year(!) ago at the beginning of milestone. I'm surprised why the team spends so much effort on releasing monthly previews if no one uses them even with Azure.

[SteveL-MSFT]

@iSazonov agree that this should have been found earlier and I've given the reporting team feedback to be actively testing against our previews. When did we add the content-type to POST?

[iSazonov]

When did we add the content-type to POST?

Feb 15, 2022 #19152

[SteveL-MSFT]

The @PowerShell/wg-powershell-cmdlets reviewed this. Given that there hasn't been reports of experienced regression of the change in POST behavior with regards to the content-type header since that change was more than 2 years ago, we would suggest not changing that. However, since there has already been reports of users experiencing regressions moving to 7.4 with the new PUT behavior of adding the content-type header, we agreed to revert the PUT behavior change. Although curl does not add the content-type header whether POST or PUT is used, we can continue to keep the current POST behavior in the web cmdlets as there hasn't been reports of issues.

[daxian-dbw]

LGTM

[Moazzem-Hossain-pixel]

Thanks