New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency nuget instructions for PowerShell.Core.Instrumentation resource binary #5396
Changes from 7 commits
c90eaf5
74bdbb3
8902527
da71450
ed2c484
f60a430
8b150a5
51f99f7
ed7fad9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd"> | ||
<metadata> | ||
<id>PowerShell.Core.Instrumentation</id> | ||
<version>6.0.0-beta.9</version> | ||
<authors>Microsoft</authors> | ||
<owners>Microsoft</owners> | ||
<requireLicenseAcceptance>false</requireLicenseAcceptance> | ||
<description>PowerShell Core ETW resource binary</description> | ||
<copyright>(c) Microsoft Corporation. All rights reserved.</copyright> | ||
</metadata> | ||
</package> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,7 @@ | |
<PackageReference Include="System.Security.Permissions" Version="4.4.0" /> | ||
<PackageReference Include="System.Text.Encoding.CodePages" Version="4.4.0" /> | ||
<PackageReference Include="Microsoft.Management.Infrastructure" Version="1.0.0-alpha*" /> | ||
<PackageReference Include="PowerShell.Core.Instrumentation" Version="6.0.0-beta*" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it depended by System.Management.Automation.dll or powershell as a whole? Put it another way, if an application is hosting System.Management.Automation.dll only, does it need the resource dll to work properly? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. None of the code has a direct dependency on the binary. I chose SMA to pull the nuget package since it contains the event raising code. If the dll is not present or the manifest isn't registered, PowerShell will continue to work without issue but the event log and custom consumers won't be able to decode the events. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the clarification. #Close |
||
</ItemGroup> | ||
|
||
<PropertyGroup> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove "Core"? It seems we did this previously.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, we use PowerShell Core all across our .MD files in the repo. (547 times). I figured I'd follow that pattern as well as ensure that there is no confusion between this and Windows PowerShell. That's also the reason I selected the assembly name.