Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escape string translation when generating a resx file from the PowerShell ETW manifest #5892

Merged
merged 1 commit into from Jan 19, 2018
Merged

Conversation

dantraMSFT
Copy link
Contributor

PR Summary

Fixes #5890

The original resx generator misconfigured the translation table for translating message resource escape characters to string escape characters. The change fixes the escapeStrings table and includes the regenerated resx file.

The resx file is used on Linux and MacOS for writing the equivalent of ETW events to the system log files.

PR Checklist

Note: Please mark anything not applicable to this PR NA.

@lzybkr
Copy link
Member

lzybkr commented Jan 13, 2018

How about just using my original suggestion: #5144 (comment)

@dantraMSFT
Copy link
Contributor Author

@daxian-dbw, @TravisEz13, @adityapatwardhan: Do you guys have any feedback on this?

Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated resource strings look good to me.

@daxian-dbw daxian-dbw self-assigned this Jan 18, 2018
@daxian-dbw daxian-dbw merged commit 65a4002 into PowerShell:master Jan 19, 2018
@dantraMSFT dantraMSFT deleted the dantra/issue5890 branch January 19, 2018 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resxgen.psm1 is not translating manifest escape characters.
4 participants