New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'more' function and move the $env:PAGER capability into the help function #6059
Merged
Merged
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
87c24d8
[Feature] Add pipeline support in 'more' function
iSazonov 83f241d
Pass non-string objects through formatting system
iSazonov e6c11fd
Use formatting system
iSazonov 641c5a4
Revert "Use formatting system"
iSazonov 09a6bdf
Revert "Pass non-string objects through formatting system"
iSazonov 3cc2c84
Revert "[Feature] Add pipeline support in 'more' function"
iSazonov 7a3b9f4
Remove 'more' function and move the $env:PAGER capability into the he…
iSazonov a9b72eb
Merge branch 'master' into more-support-pipeline
iSazonov b25acd9
[Feature] Remove 'more' alias test
iSazonov bdee0ec
Add support arguments in Pager
iSazonov a792bd4
Refactor help function
iSazonov 31ab358
Add test for Strict Mode
iSazonov b6f60be
Fix typo
iSazonov File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will lose the ability to specify arguments to the pager utility -
$pager,$moreArgs = $env:PAGER -split '\s+'
. That doesn't bother me personally but presumably somebody added these for a reason (an issue I suspect).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that was explicitly to fix #6142
Should just use the same code as from https://github.com/PowerShell/PowerShell/pull/6144/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reminder!
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add tests to exclude such regression?