-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken links due to PR 6899 that removed GitHub docs on installation docs, known issues and breaking changes due to complete migration to docs.microsoft.com #6981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.github/ISSUE_TEMPLATE.md
Outdated
@@ -8,7 +8,7 @@ If it is a bug report: | |||
You can install the latest version from https://github.com/PowerShell/PowerShell/releases | |||
- Search the existing issues. | |||
- Refer to the [FAQ](https://github.com/PowerShell/PowerShell/blob/master/docs/FAQ.md). | |||
- Refer to the [known issues](https://github.com/PowerShell/PowerShell/blob/master/docs/KNOWNISSUES.md). | |||
- Refer to the [known issues](https://docs.microsoft.com/en-us/powershell/scripting/whats-new/known-issues-ps6?view=powershell-6). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should drop the en-us
part from the url. So it will redirect to appropriate language according to locale. @sdwheeler am I correct?
README.md
Outdated
[in-archlinux]: https://github.com/PowerShell/PowerShell/tree/master/docs/installation/linux.md#arch-linux | ||
[in-appimage]: https://github.com/PowerShell/PowerShell/tree/master/docs/installation/linux.md#linux-appimage | ||
[in-macos]: https://github.com/PowerShell/PowerShell/tree/master/docs/installation/macos.md | ||
[in-windows]: https://docs.microsoft.com/en-us/powershell/scripting/setup/installing-powershell-core-on-windows?view=powershell-6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above comment about en-us
also applies to all urls here.
@adityapatwardhan I removed the en-us culture in the links |
Assuming this PR looks good, it needs to be merged. Not cool having the install instructions links be broken for multiple days. Props to @bergmeister for fixing this! |
PR Summary
To fix broken links due to PR #6899 and remove unnecessary spelling items
Fixes #6983
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
to the beginning of the title and remove the prefix when the PR is ready.[feature]
if the change is significant or affects feature tests