Update links that contain 'en-us' culture #7013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if possible) and in some cases update to newer re-directed link to docs.microsoft.com
bergmeister
requested review from
adityapatwardhan,
anmenaga,
BrucePay,
dantraMSFT,
daxian-dbw,
HemantMahawar,
JamesWTruher,
joeyaiello,
mirichmo,
PaulHigin,
SteveL-MSFT and
TravisEz13
as code owners
daxian-dbw
approved these changes
Jun 6, 2018
dantraMSFT
suggested changes
Jun 6, 2018
demos/DSC/readme.md
Outdated
| Note: applying the DSC configuration requires privileges. The user must have sudo authorization capabilities. You will be prompted for a sudo password when running the demo. |
There was a problem hiding this comment.
Suggestion: Since you're changing this text, consider using > to indicate a note.
Note: applying the....
docs/learning-powershell/README.md
Outdated
| @@ -112,7 +112,7 @@ Recommended Training and Reading | |||
| - [Learn PowerShell Video Library][powershell.com-learn-powershell] from PowerShell.com | |||
| - [PowerShell Quick Reference Guides][quick-reference] by PowerShellMagazine.com | |||
| - [PowerShell 5 How-To Videos][script-guy-how-to] by Ed Wilson | |||
| - [PowerShell TechNet Resources](https://technet.microsoft.com/en-us/scriptcenter/dd742419.aspx) from ScriptCenter | |||
| - [PowerShell TechNet Resources](https://technet.microsoft.com/scriptcenter/dd742419.aspx) from ScriptCenter | |||
There was a problem hiding this comment.
This redirects to PowerShell Documentation
| @@ -18,7 +18,7 @@ internal static class TelemetryWrapper | |||
| /// <summary> | |||
| /// Performing EventSource initialization in the Static Constructor since this is thread safe. | |||
| /// Static constructors are guaranteed to be run only once per application domain, before any instances of a class are created or any static members are accessed. | |||
| /// https://msdn.microsoft.com/en-us/library/aa645612(VS.71).aspx | |||
| /// https://msdn.microsoft.com/library/aa645612(VS.71).aspx | |||
There was a problem hiding this comment.
That link points to retired content. This one is probably more appropriate:
There was a problem hiding this comment.
Good point. I was wondering if it was worth updating a link about Visual Studio 2003 but your link makes more sense (there were a few places with a similar link)
dantraMSFT
approved these changes
Jun 7, 2018
14 tasks
ghost
pushed a commit
that referenced
this pull request
May 15, 2020
# PR Summary * remove explicit en-us from links * remove view parameter ## PR Context follow-up #7013 ## PR Checklist - [x] [PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - Use the present tense and imperative mood when describing your changes - [x] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [x] [Make sure all `.h`, `.cpp`, `.cs`, `.ps1` and `.psm1` files have the correct copyright header](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [x] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress). - If the PR is work in progress, please add the prefix `WIP:` or `[ WIP ]` to the beginning of the title (the `WIP` bot will keep its status check at `Pending` while the prefix is present) and remove the prefix when the PR is ready. - **[Breaking changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#making-breaking-changes)** - [ ] None - **OR** - [ ] [Experimental feature(s) needed](https://github.com/MicrosoftDocs/PowerShell-Docs/blob/staging/reference/6/Microsoft.PowerShell.Core/About/about_Experimental_Features.md) - [ ] Experimental feature name(s): <!-- Experimental feature name(s) here --> - **User-facing changes** - [x] Not Applicable - **OR** - [ ] [Documentation needed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) - [ ] Issue filed: <!-- Number/link of that issue here --> - **Testing - New and feature** - [x] N/A or can only be tested interactively - **OR** - [ ] [Make sure you've added a new test if existing tests do not effectively test the code changed](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#before-submitting) - **Tooling** - [x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted. - **OR** - [ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include: - Impact on [PowerShell Editor Services](https://github.com/PowerShell/PowerShellEditorServices) which is used in the [PowerShell extension](https://github.com/PowerShell/vscode-powershell) for VSCode (which runs in a different PS Host). - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features. - Impact on [PSScriptAnalyzer](https://github.com/PowerShell/PSScriptAnalyzer) (which provides linting & formatting in the editor extensions). - Impact on [EditorSyntax](https://github.com/PowerShell/EditorSyntax) (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Update links that contain
en-usculture to removeen-usculture (if possible) and in some cases update to newer re-directed link to docs.microsoft.comThe new links were manually tested (using Chrome).
Note that there are still 2 links with the
en-usculture left in the repo that could not be updated because they would not work without it theen-uspart:cc @sdwheeler
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests