Fix sdk package #7431
Merged
Fix sdk package #7431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
requested review from
anmenaga,
dantraMSFT and
daxian-dbw
as code owners
TravisEz13
approved these changes
Aug 1, 2018
TravisEz13
reviewed
Aug 1, 2018
| @@ -1426,7 +1426,8 @@ function New-UnifiedNugetPackage | |||
| "Microsoft.PowerShell.SDK.dll", | |||
| "Microsoft.WSMan.Management.dll", | |||
| "Microsoft.WSMan.Runtime.dll", | |||
| "System.Management.Automation.dll") | |||
| "System.Management.Automation.dll", | |||
There was a problem hiding this comment.
NIT: with this format, the commas aren't needed and if you close it on a new line you won't delete a line each time you add an entry.
There was a problem hiding this comment.
👍 Don't what to make this change now if you are ok with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7339
PR Summary
SDK has some missing dependencies which makes the SDK unusable.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests