Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C#-style type accelerators and suffixes for ushort, uint, ulong, and short literals #7813

Merged
merged 12 commits into from Sep 28, 2018
Merged

Add C#-style type accelerators and suffixes for ushort, uint, ulong, and short literals #7813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f9d9626
Add CharTraits to suffix characters for additional numeric types
vexx32 Sep 18, 2018
2bccd8d
Add tokenizing logic for parsing short and unsigned values
vexx32 Sep 18, 2018
401a354
Add tests for parsing new numeric types
vexx32 Sep 18, 2018
af1b63e
Add type accelerators for friendly names of types
vexx32 Sep 18, 2018
5271276
Add tests for new type accelerators
vexx32 Sep 18, 2018
0cbbed1
Codefactor space-after-braces fixes
vexx32 Sep 25, 2018
84b90be
Address tokenizer comments
vexx32 Sep 28, 2018
150eda3
Address comments on the parser tests
vexx32 Sep 28, 2018
af72269
Add should-fail case for super-high fallthrough on ushort
vexx32 Sep 28, 2018
36ff4f6
Use pattern matching in `out` params
vexx32 Sep 28, 2018
5986b38
Change var name to not conflict with prior pattern matching
vexx32 Sep 28, 2018
d1d46b2
Add additional should-fail for `us` suffix with reals and multiplier
vexx32 Sep 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/System.Management.Automation/engine/parser/CharTraits.cs
View file
Open in desktop
Expand Up @@ -155,9 +155,9 @@ static CharExtensions()
/* P */ CharTraits.IdentifierStart | CharTraits.VarNameFirst | CharTraits.MultiplierStart,
/* Q */ CharTraits.IdentifierStart | CharTraits.VarNameFirst,
/* R */ CharTraits.IdentifierStart | CharTraits.VarNameFirst,
/* S */ CharTraits.IdentifierStart | CharTraits.VarNameFirst,
/* S */ CharTraits.IdentifierStart | CharTraits.VarNameFirst | CharTraits.TypeSuffix,
/* T */ CharTraits.IdentifierStart | CharTraits.VarNameFirst | CharTraits.MultiplierStart,
/* U */ CharTraits.IdentifierStart | CharTraits.VarNameFirst,
/* U */ CharTraits.IdentifierStart | CharTraits.VarNameFirst | CharTraits.TypeSuffix,
/* V */ CharTraits.IdentifierStart | CharTraits.VarNameFirst,
/* W */ CharTraits.IdentifierStart | CharTraits.VarNameFirst,
/* X */ CharTraits.IdentifierStart | CharTraits.VarNameFirst,
Expand Down Expand Up @@ -187,9 +187,9 @@ static CharExtensions()
/* p */ CharTraits.IdentifierStart | CharTraits.VarNameFirst | CharTraits.MultiplierStart,
/* q */ CharTraits.IdentifierStart | CharTraits.VarNameFirst,
/* r */ CharTraits.IdentifierStart | CharTraits.VarNameFirst,
/* s */ CharTraits.IdentifierStart | CharTraits.VarNameFirst,
/* s */ CharTraits.IdentifierStart | CharTraits.VarNameFirst | CharTraits.TypeSuffix,
/* t */ CharTraits.IdentifierStart | CharTraits.VarNameFirst | CharTraits.MultiplierStart,
/* u */ CharTraits.IdentifierStart | CharTraits.VarNameFirst,
/* u */ CharTraits.IdentifierStart | CharTraits.VarNameFirst | CharTraits.TypeSuffix,
/* v */ CharTraits.IdentifierStart | CharTraits.VarNameFirst,
/* w */ CharTraits.IdentifierStart | CharTraits.VarNameFirst,
/* x */ CharTraits.IdentifierStart | CharTraits.VarNameFirst,
Expand Down
8 changes: 4 additions & 4 deletions src/System.Management.Automation/engine/parser/TypeResolver.cs
View file
Open in desktop
Expand Up @@ -739,7 +739,7 @@ internal static class CoreTypes
{ typeof(Guid), new[] { "guid" } },
{ typeof(Hashtable), new[] { "hashtable" } },
{ typeof(int), new[] { "int", "int32" } },
{ typeof(Int16), new[] { "int16" } },
{ typeof(Int16), new[] { "short", "int16" } },
{ typeof(long), new[] { "long", "int64" } },
{ typeof(CimInstance), new[] { "ciminstance" } },
{ typeof(CimClass), new[] { "cimclass" } },
Expand Down Expand Up @@ -770,9 +770,9 @@ internal static class CoreTypes
{ typeof(BigInteger), new[] { "bigint" } },
{ typeof(SecureString), new[] { "securestring" } },
{ typeof(TimeSpan), new[] { "timespan" } },
{ typeof(UInt16), new[] { "uint16" } },
{ typeof(UInt32), new[] { "uint32" } },
{ typeof(UInt64), new[] { "uint64" } },
{ typeof(UInt16), new[] { "ushort", "uint16" } },
{ typeof(UInt32), new[] { "uint", "uint32" } },
{ typeof(UInt64), new[] { "ulong", "uint64" } },
{ typeof(Uri), new[] { "uri" } },
{ typeof(ValidateCountAttribute), new[] { "ValidateCount" } },
{ typeof(ValidateDriveAttribute), new[] { "ValidateDrive" } },
Expand Down