Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aliases #786

Merged
merged 4 commits into from Apr 8, 2016
Merged

Fix aliases #786

merged 4 commits into from Apr 8, 2016

Conversation

andyleejordan
Copy link
Member

Remove conflicting aliases for Linux and OS X

The aliases which conflict with Linux native commands were consolidated
and removed with the pre-processor definition LINUX. Additionally,
several "conflicts" are purposefully kept and likewise consolidated.
They are kept because Bash itself stomps on the native commands with its
own built-ins, and so we're adopting the same behavior.

Resolves #567.

Remove A:...Z: drive functions on Linux / OS X

Resolves #612.


This change is Reviewable

The aliases which conflict with Linux native commands were consolidated
and removed with the pre-processor definition `LINUX`. Additionally,
several "conflicts" are purposefully kept and likewise consolidated.
They are kept because Bash itself stomps on the native commands with its
own built-ins, and so we're adopting the same behavior.

The `clear` and `more` aliases are edge cases where the functions they
call are already fixed for Linux, and so we keep these too.

Resolves #567.
@andyleejordan
Copy link
Member Author

Merging because reviewed in-person with @JamesWTruher.

@andyleejordan andyleejordan merged commit 3582bb4 into master Apr 8, 2016
@andyleejordan andyleejordan deleted the andschwa/remove-aliases branch April 8, 2016 23:07
@andyleejordan andyleejordan mentioned this pull request Apr 28, 2016
@kilasuit kilasuit mentioned this pull request Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant