Change default of Start-PSBuild to include -PSModuleRestore
#7881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
approved these changes
Sep 27, 2018
iSazonov
approved these changes
Sep 28, 2018
TravisEz13
reviewed
Oct 1, 2018
build.psm1
Outdated
| @@ -448,6 +451,11 @@ function Start-PSBuild { | |||
| [string]$ReleaseTag | |||
| ) | |||
|
|
|||
| if (!$NoPSModuleRestore) | |||
There was a problem hiding this comment.
This should only be done for the default parameter set
There was a problem hiding this comment.
It'll do the wrong thing for -PSModuleRestore:$false or equivalent
TravisEz13
approved these changes
Oct 1, 2018
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Most of the time when building PowerShell privately to validate a fix, it is desirable to include the modules that normally ship with PowerShell Core. Without explicitly setting
-PSModuleRestoreyou'll immediately notice that PSReadLine is not there so you do another build with that switch. This change makes-PSModuleRestoredefault adding a-NoPSModuleRestorefor cases where you don't want the modules. The-PSModuleRestoreswitch is retained for compatibility reasons.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests