New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace StringComparision.CurrentCulture with StringComparision.Ordinal #8068
Conversation
src/Microsoft.WSMan.Management/WSManConnections.cs, line 143 at r1 (raw file):
I've seen this in many places, perhaps we should have a central place for this code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 24 of 24 files at r1.
Reviewable status: complete! all files reviewed
We probably should fix this one as well:
|
Thinking about it further with @JamesWTruher , Hashtable could be culture sensitive in some cases. This should be a different PR and probably be behind an experimental flag. |
@TravisEz13 In the PR I fixed only obvious cases. There are still about 30 unclear cases left. It would be great if MSFT team reviewed them.
If we should please open a tracking issue and I'll fix this later. |
PR Summary
Related #8064
Replace StringComparision.CurrentCulture with StringComparision.Ordinal.
Best Practices for Using Strings in .NET
Not all code base is fixed. There are not obvious cases.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
to the beginning of the title and remove the prefix when the PR is ready.[feature]
if the change is significant or affects feature testsThis change is