Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notes about ITuple changes(#7633) from v6.2.0-preview.1 updates. #8101

Merged
merged 1 commit into from Nov 5, 2018
Merged

Conversation

stknohg
Copy link
Contributor

@stknohg stknohg commented Oct 22, 2018

PR Summary

Related #8070, #8077.

The notes of #7633 was already included in PowerShell Core 6.1.0 stable.

Note: We also must update Release notes of v6.2.0-preview.1.

PR Checklist

Copy link
Contributor

@anmenaga anmenaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing change log is probably too late.
But we can manually update description of the v6.2.0-preview.1 release.

@iSazonov
Copy link
Collaborator

The update is useful for next release.

@iSazonov iSazonov closed this Oct 23, 2018
@iSazonov iSazonov reopened this Oct 23, 2018
@iSazonov
Copy link
Collaborator

Reopen PR to restart CIs.

@stknohg
Copy link
Contributor Author

stknohg commented Nov 2, 2018

Currently, WIP is required.
Do I need to do something?

@iSazonov
Copy link
Collaborator

iSazonov commented Nov 2, 2018

@SteveL-MSFT @TravisEz13 Can we fix the change log issue?

@SteveL-MSFT
Copy link
Member

If the changelog is wrong, we should fix it. We can ignore the WIP bot since it's clear it doesn't apply to this PR.

@iSazonov
Copy link
Collaborator

iSazonov commented Nov 2, 2018

@TravisEz13 Please merge the PR.

@TravisEz13 TravisEz13 merged commit 03ba61c into PowerShell:master Nov 5, 2018
@stknohg stknohg deleted the fix-8070 branch November 12, 2018 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants