Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding yml for Windows Release builds #8374

Merged
merged 23 commits into from Dec 7, 2018

Conversation

anmenaga
Copy link
Contributor

PR Summary

As part of improving the build process, the UI build pipeline for Windows Builds was converted to a yml-based pipeline. (everything minus compliance tasks)
Verified on AzureDevOps mirror (pipeline WIP-PowerShellCore-WindowsBuild-Yaml): automated and manual runs.

PR Checklist

@anmenaga
Copy link
Contributor Author

anmenaga commented Dec 4, 2018

Fixed CodeFactor issues.

@anmenaga
Copy link
Contributor Author

anmenaga commented Dec 4, 2018

@adityapatwardhan pls look again.

@TravisEz13 TravisEz13 changed the title Adding yml for Windows builds Adding yml for Windows Release builds Dec 5, 2018
Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than comments

Copy link
Member

@adityapatwardhan adityapatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments are non-blocking


- powershell: |
docker container prune --force
docker container ls --all --format '{{ json .ID }}' | ConvertFrom-Json | %{docker container rm --force --volumes $_}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change % to ForEach-Object

condition: and(succeeded(), ne(variables['SkipFxDependent'], 'true'))

- powershell: |
docker image ls --format '{{ json .}}'|ConvertFrom-Json|% {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change % to ForEach-Object


- powershell: |
docker container prune --force
docker container ls --all --format '{{ json .ID }}' | ConvertFrom-Json | %{docker container rm --force --volumes $_}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change % to ForEach-Object

continueOnError: true

- powershell: |
docker image ls --format '{{ json .}}'|ConvertFrom-Json|% {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change % to ForEach-Object

@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Dec 7, 2018
@TravisEz13 TravisEz13 merged commit a1299cd into PowerShell:master Dec 7, 2018
TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Maintainers-Build specific to affecting the build CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants