Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capitalization cases for PoshChan #9188

Merged
merged 8 commits into from Mar 23, 2019
Merged

Fix capitalization cases for PoshChan #9188

merged 8 commits into from Mar 23, 2019

Conversation

RDIL
Copy link
Contributor

@RDIL RDIL commented Mar 21, 2019

PR Summary

The jobs name is fully lowercase
Fixes the issue found by @iSazonov

PR Context

PR Checklist

@RDIL RDIL changed the title Fix macOS Fix macOS for PoshChan Mar 21, 2019
@iSazonov
Copy link
Collaborator

The same for "linux"

@SteveL-MSFT Can it be case-insensetive?

@SteveL-MSFT
Copy link
Member

@PoshChan Please rebuild mAcOS

@PoshChan
Copy link
Collaborator

@SteveL-MSFT, could not find a matching build target

@RDIL
Copy link
Contributor Author

RDIL commented Mar 23, 2019

@SteveL-MSFT typo

@SteveL-MSFT
Copy link
Member

@RDIL testing case-insensitivity which is what I expected

@RDIL
Copy link
Contributor Author

RDIL commented Mar 23, 2019

Oh

@SteveL-MSFT
Copy link
Member

Intent was to be case-insensitive, but forgot that ConvertFrom-Json -AsHashTable results in a case-sensitive hashtable. I believe I can fix this on the server side.

@SteveL-MSFT
Copy link
Member

@PoshChan-Staging Please rebuild MACos

@PoshChan-Staging
Copy link
Collaborator

@SteveL-MSFT, successfully started rebuild of PowerShell-CI-macOS

@SteveL-MSFT
Copy link
Member

@PoshChan please rebuild linux

@PoshChan
Copy link
Collaborator

@SteveL-MSFT, all requests start with the magic word Please.

@RDIL
Copy link
Contributor Author

RDIL commented Mar 23, 2019

lol

@SteveL-MSFT
Copy link
Member

@PoshChan-Staging please rebuild LINux

@PoshChan-Staging
Copy link
Collaborator

@SteveL-MSFT, successfully started rebuild of PowerShell-CI-Linux

@SteveL-MSFT
Copy link
Member

@PoshChan pLeASE rEbuild wINDOws

@PoshChan
Copy link
Collaborator

@SteveL-MSFT, successfully started rebuild of PowerShell-CI-windows

@SteveL-MSFT
Copy link
Member

Ok, I believe @PoshChan is fully case-insensitive now :)

So, this PR isn't necessary except for aesthetic reasons. But then you might as well fix Windows, macOS, and Linux with "correct" casing :)

@RDIL RDIL changed the title Fix macOS for PoshChan Fix capitalization cases for PoshChan Mar 23, 2019
.poshchan/settings.json Outdated Show resolved Hide resolved
.poshchan/settings.json Outdated Show resolved Hide resolved
.poshchan/settings.json Outdated Show resolved Hide resolved
SteveL-MSFT and others added 2 commits March 23, 2019 08:43
Co-Authored-By: RDIL <me@rdil.rocks>
Co-Authored-By: RDIL <me@rdil.rocks>
Co-Authored-By: RDIL <me@rdil.rocks>
@TravisEz13 TravisEz13 merged commit c0cce10 into PowerShell:master Mar 23, 2019
@RDIL RDIL deleted the patch-5 branch March 23, 2019 20:33
@TravisEz13 TravisEz13 added this to the 6.3.0-preview.1 milestone Mar 29, 2019
@TravisEz13 TravisEz13 added CL-Tools Indicates that a PR should be marked as a tools change in the Change Log and removed CL-Untagged labels Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Tools Indicates that a PR should be marked as a tools change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants