Do not resolve host name as local domain name. #424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When user name is same as computer name, the user name looks like oldium\OLDIUM. Prevent calling TranslateNameW when the domain name part is same as computer name - otherwise we run twice into TranslateNameW timeouts. Symptoms in logs: error: lookup_principal_name: User principal name lookup failed for user 'oldium\\oldium' (explicit: 1355, implicit: 1355) Signed-off-by: Oldřich Jedlička <oldium.pro@gmail.com>
|
It looks like there are failed tests |
oldium
changed the title
bagajjal
reviewed
Apr 3, 2020
|
Closing, have already a better fix in #469, which works with mentioned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user name is same as computer name, the user name looks like
oldium\OLDIUM. Prevent callingTranslateNameWwhen the domain name part is same as computer name - otherwise we run twice intoTranslateNameWtimeout and it takes more than 30 seconds to login.Symptoms in logs: