Added -Scope to the Resource to fix bugs with narrower scope always m… #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aking Test-TargetResource returning false. Signed-off-by: Hans O. Martinsen
added 2 commits
October 19, 2016 22:26
Signed-off-by: Hans O. Martinsen
Signed-off-by: Hans O. Martinsen
|
Reviewed 3 of 4 files at r1, 2 of 2 files at r2. Comments from Reviewable |
BerheAbrha
reviewed
Nov 16, 2016
| } | ||
|
|
||
| It 'Returns correct execution policy for the correct Scope' { | ||
| $result = Get-TargetResource -ExecutionPolicy $(Get-ExecutionPolicy) -Scope 'LocalMachine' |
There was a problem hiding this comment.
ExecutionPolicy [](start = 68, length = 15)
I think you need to specify the parameter -Scope 'LocalMachine' in this and the line below.
BerheAbrha
reviewed
Nov 16, 2016
|
|
||
| It 'Returns correct execution policy for the correct Scope' { | ||
| $result = Get-TargetResource -ExecutionPolicy $(Get-ExecutionPolicy) -Scope 'LocalMachine' | ||
| $result.ExecutionPolicy | should be $(Get-ExecutionPolicy) |
There was a problem hiding this comment.
Get-ExecutionPolicy [](start = 54, length = 19)
Same comment as above.
|
🕐 |
eshaparmar
added
waiting for author response
|
@HansOMartinsen are you able to work on this PR if I review? If so could you start by rebasing (git rebase) this PR to resolve the conflict? If you can’t work on this then let us know and someone else could continue the work. Thanks! |
johlju
added
abandoned
|
Closing this as this is being worked on in PR #15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aking Test-TargetResource returning false.
Signed-off-by: Hans O. Martinsen
This change is