BREAKING CHANGE: Add Scope option #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aking Test-TargetResource returning false. Signed-off-by: Hans O. Martinsen
Signed-off-by: Hans O. Martinsen
Signed-off-by: Hans O. Martinsen
|
@kwirkykat how can I get someone to review this PR so it can be merged? |
|
@GerbenWelter This is a breaking change because it changes the default behavior of the resource without the Scope parameter. Before it would apparently retrieve the execution policy for the current session/user whereas now it will get the execution policy for the whole machine/all users. I think this is the correct design change to make though, so I will accept the breaking change. Can you please remove the DscResource.Tests common module from your branch? It should be in the .gitignore but apparently it isn't in this repo. |
kwirkykat
added
the
breaking change
kwirkykat
added
the
waiting for author response
|
I messed up by deleting my fork of this repo on GitHub. I made a new PR: #12. Closing this PR. |
kwirkykat
pushed a commit
that referenced
this pull request
Dec 6, 2017
* Added -Scope to the Resource to fix bugs with narrower scope always making Test-TargetResource returning false. Signed-off-by: Hans O. Martinsen * Fixed MOF file bug as well as updated Readme.md with unreleased feature. Signed-off-by: Hans O. Martinsen * Used ISE to edit MOF file, big mistake, reencoded to ASCII Signed-off-by: Hans O. Martinsen * Delete trailing whitespace and applied review comment by @BerheAbrha. * Remove DSCResource.Tests as asked by @kwirkykat * Add Scope option to xPowerShellExecutionPolicy section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the work (#9) of @HansOMartinsen (who seems to be MIA) and added the changes suggested by reviewer @BerheAbrha.
This fixes #8.
This change is