BREAKING CHANGE: Add Scope option (continuation of #11) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aking Test-TargetResource returning false. Signed-off-by: Hans O. Martinsen
Signed-off-by: Hans O. Martinsen
Signed-off-by: Hans O. Martinsen
|
@kwirkykat do you need anything from me to get this merged? |
kwirkykat
suggested changes
Nov 23, 2017
kwirkykat
added
the
breaking change
kwirkykat
changed the title
|
@kwirkykat I have updated the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kwirkykat I somehow had deleted the repo from GitHub #11 was based on. I have forked it again deleted the DSCResource.Tests as you asked and push my branch again. Thanks fo reviewing and accepting the change,
This PR builds on the work (#9) of @HansOMartinsen (who seems to be MIA) and added the changes suggested by reviewer @BerheAbrha.
This fixes #8.
This change is