(maint) update installer script #8
Conversation
ferventcoder
commented
Sep 2, 2015
ferventcoder
commented
- If TEMP variable is null, set a default one.
- 7zip should not open a window while unpacking
- Set default installation location for path to updated default location
- If TEMP variable is null, set a default one. - 7zip should not open a window while unpacking - Set default installation location for path to updated default location
| @@ -229,7 +232,7 @@ function InstallChoco | |||
|
|
|||
| # unzip the package | |||
| Write-verbose "Extracting $file to $tempDir..." | |||
| Start-Process "$7zaExe" -ArgumentList "x -o`"$tempDir`" -y `"$file`"" -Wait | |||
| Start-Process "$7zaExe" -ArgumentList "x -o`"$tempDir`" -y `"$file`"" -Wait -NoNewWindow | |||
There was a problem hiding this comment.
@dlwyatt I was a bit curious if this causes issues...
There was a problem hiding this comment.
No idea. Considering the source of the code, I figured I'd just merge it. :)
There was a problem hiding this comment.
I just wasn't sure if there was some reason on this NOT to include the output. It gets a bit chatty and not in a verbose logging kind of way. :)
There was a problem hiding this comment.
Pulled down the merge and run some tests, all seems to be well.
The original reason for including the installer script in the DSC was to refactor the use of Write-Host as it isn't support when running under DSC.
I'll look to revisit as may be a more elegant way to work around this to have it pull down the latest installer from chocolatey.org, which would be much nicer. Added it to the issues list #10.
