Skip to content
This repository has been archived by the owner on Apr 24, 2020. It is now read-only.

Add chruby options #816

Merged
merged 3 commits into from Jul 10, 2018
Merged

Add chruby options #816

merged 3 commits into from Jul 10, 2018

Conversation

opes
Copy link
Contributor

@opes opes commented Apr 30, 2018

Refactors and adds options for the chruby segment. Documentation updated accordingly.

@opes opes closed this Apr 30, 2018
@opes opes reopened this Apr 30, 2018
@bhilburn bhilburn changed the base branch from master to next May 23, 2018 14:00
@bhilburn bhilburn changed the base branch from next to master May 23, 2018 14:00
@bhilburn
Copy link
Member

@opes - Wow, this is a really well-done PR. Based on your use of P9k's internal functions and adherence to coding guidelines, I wouldn't have guessed that this was your first PR. Nice work!

As a new feature, we need to merge this into next rather than master to keep things stable. Unfortunately, I can't re-target this PR because it would pull in a bunch of commits from master. So, I tried doing the master merge manually first, and actually triggered several conflicts, at least one of which is in the Ruby segment code.

So, anyway, this is a long way of saying I need to sort this out, and then will merge this into next, hah.

@opes
Copy link
Contributor Author

opes commented May 31, 2018

Thanks for following up, @bhilburn! Let me know if there's anything I need to do on my end to assist.

@dritter dritter mentioned this pull request Jun 7, 2018
@bhilburn bhilburn merged commit fbb85e7 into Powerlevel9k:master Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants