Add option to allow bonus points in assessments #4090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
jonatanschroeder
moved this from In progress
to Review in progress
in Summer 2021 Development
|
Sorry about the moves up there, the GitHub app, when you open the details of a PR, gives you a Close button that I thought would close the details page, but it closes the PR instead without warning. |
nwalters512
approved these changes
May 28, 2021
There was a problem hiding this comment.
Sorry for all the nits - grading is some of the most complex and potentially confusing stuff in PrairieLearn, so I want to make sure it's as clear and documented as possible! This looks good on the whole though.
I won't merge this quite yet in case Matt gets a chance to look later today - I'd trust his review of grading code more than my own 🙂
Summer 2021 Development
automation
moved this from Review in progress
to Reviewer approved
May 28, 2021
Co-authored-by: Nathan Walters <nathan@prairielearn.com>
mwest1066
reviewed
May 29, 2021
Co-authored-by: Matthew West <matt@prairielearn.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option allows an assessment to have a score percentage over 100%.