fix: Set timeout for GitHub Actions workflow #5503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwalters512
commented
Mar 10, 2022
.github/workflows/main.yml
Outdated
| runs-on: ubuntu-latest | ||
| timeout-minutes: 30 |
There was a problem hiding this comment.
This is a little over 2x the average time our CI runs take. If this exceeds that in the future, we can tweak this.
Although... this doesn't account for a PR where we need to rebuild a bunch of images. Maybe setting the timeout specifically on the JS tests step would be better? I don't think we've seen other things frequently time out.
There was a problem hiding this comment.
I ended up making this change in d6f233b.
mwest1066
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the scenario where CI runs for 6 hours after the JS tests get stuck 馃槵