Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set timeout for GitHub Actions workflow #5503

Merged
merged 3 commits into from Mar 11, 2022
Merged

fix: Set timeout for GitHub Actions workflow #5503

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6156c20
fix: Set timeout for GitHub Actions workflow
nwalters512 Mar 10, 2022
d6f233b
Move timeout to individual step
nwalters512 Mar 10, 2022
6e43719
Merge branch 'master' into fix/github-actions-job-timeout
nwalters512 Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Expand Up @@ -4,7 +4,6 @@ on: [push, pull_request]

jobs:
build:

runs-on: ubuntu-latest

steps:
Expand Down Expand Up @@ -55,6 +54,11 @@ jobs:
run: docker exec test_container /PrairieLearn/docker/typecheck_python.sh
- name: Run the JavaScript tests
run: docker exec test_container /PrairieLearn/docker/test_js.sh
# The JS tests hang relatively often when someone makes a mistake in a PR,
# and the GitHub Actions default timeout is 6 hours, so the CI run keeps
# spinning until it eventually times out. This shorter timeout helps
# ensure that the tests fail more quickly so that people can fix them.
timeout-minutes: 30
- name: Run the Python tests
run: docker exec test_container /PrairieLearn/docker/test_python.sh
- name: Copy code-coverage data out of container
Expand Down