Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force fabric to install newer version of jsdom #9876

Closed
wants to merge 1 commit into from

Conversation

nwalters512
Copy link
Contributor

This avoids the need to install a version of jsdom that ultimately isn't used, as we strictly use fabric in the browser.

I originally did this in #9840, but opted to lift into a separate PR to minimize the number of changes there, and so that we could see the impact on our image size.

Related: fabricjs/fabric.js#6885

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.41%. Comparing base (fffa876) to head (8614e3d).
Report is 340 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9876   +/-   ##
=======================================
  Coverage   66.41%   66.41%           
=======================================
  Files         453      453           
  Lines       70289    70289           
  Branches     5645     5646    +1     
=======================================
  Hits        46681    46681           
+ Misses      23184    23183    -1     
- Partials      424      425    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

All images

Image Platform Old Size New Size Change
prairielearn/executor:8614e3dc2bf1833b49a115c1ff2ad7205a90f2ac null 1645.00 MB 1643.74 MB -0.08%
prairielearn/prairielearn:8614e3dc2bf1833b49a115c1ff2ad7205a90f2ac linux/amd64 1645.01 MB 1643.74 MB -0.08%

@jonatanschroeder
Copy link
Member

This might resolve the issue in a better way?
fabricjs/fabric.js#6885 (comment)
https://www.npmjs.com/package/fabric/v/4.6.0-browser?activeTab=dependencies

This would remove the dependency on jsdom and canvas.

@jonatanschroeder
Copy link
Member

I added #9882 mostly to check if this gets a better image size.

@nwalters512
Copy link
Contributor Author

Closing in favor of #9882.

@nwalters512 nwalters512 deleted the dedupe-fabric-jsdom branch September 12, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants