Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing-Footer #180

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

aatmajajoshi
Copy link
Contributor

@aatmajajoshi aatmajajoshi commented May 16, 2024

Title of Issue and Pull Request must be Same

Enhancing-Footer

Fixes #163

Video/Screenshots (mandatory)

Attached the working video of my deployed project:

Enhancing-Footer.mp4

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas
  • I have gone through the contributing.md file before contributing

Additional context:

Copy link

gitguardian bot commented May 16, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9250661 Triggered Generic High Entropy Secret 05aefe4 Pages/asteroid-info/script.js View secret
9250661 Triggered Generic High Entropy Secret 05aefe4 Pages/earthPics/script.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Owner

@PranavBarthwal PranavBarthwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
I saw you added an an about page, please add that inside the existing pages folder, create a new folder named about and add its html, css, js files there.

@aatmajajoshi
Copy link
Contributor Author

aatmajajoshi commented May 17, 2024 via email

@PranavBarthwal
Copy link
Owner

You need to sync your fork and pull the changes on your local repo, to see the latest changes

@aatmajajoshi
Copy link
Contributor Author

@PranavBarthwal done, can u please check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancing-Footer
2 participants