-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancing-Footer #180
base: main
Are you sure you want to change the base?
Enhancing-Footer #180
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9250661 | Triggered | Generic High Entropy Secret | 05aefe4 | Pages/asteroid-info/script.js | View secret |
9250661 | Triggered | Generic High Entropy Secret | 05aefe4 | Pages/earthPics/script.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
I saw you added an an about page, please add that inside the existing pages
folder, create a new folder named about
and add its html, css, js files there.
Hii, I can't see any existing pages folder, where is it can u guide me?
…On Thu, May 16, 2024 at 8:58 PM Pranav Barthwal ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Good work!
I saw you added an an about page, please add that inside the existing
pages folder, create a new folder named about and add its html, css, js
files there.
—
Reply to this email directly, view it on GitHub
<#180 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASUTEDJECWZOR4R22VPC45TZCTGBTAVCNFSM6AAAAABHZXZHNKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRRGE3DONZRGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
You need to sync your fork and pull the changes on your local repo, to see the latest changes |
@PranavBarthwal done, can u please check? |
Title of Issue and Pull Request must be Same
Enhancing-Footer
Fixes #163
Video/Screenshots (mandatory)
Attached the working video of my deployed project:
Enhancing-Footer.mp4
Checklist:
contributing.md
file before contributingAdditional context: