Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .born-hidden-knowl class instead of details #80

Merged

Conversation

ascholerChemeketa
Copy link
Contributor

Styling for new born hidden knowls uses details element as a selector instead of a class. Causes issues for other items that might be implemented as details like footnotes.

@ascholerChemeketa
Copy link
Contributor Author

Goes with PreTeXtBook/pretext#2094

@rbeezer
Copy link

rbeezer commented Oct 24, 2023

See comment on PreTeXtBook/pretext#2094

@rbeezer
Copy link

rbeezer commented Oct 24, 2023

Comments and beta on PreTeXtBook/pretext#2095

Read the comment, since there is a change which might require @ascholerChemeketa to adjust here.

@davidfarmer davidfarmer merged commit eec7273 into PreTeXtBook:main Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants