Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change footnotes to details/summary #2095

Conversation

ascholerChemeketa
Copy link
Contributor

Implementation for footnotes as detail summary.

Goes with:
PreTeXtBook/CSS_core#81

See there for pics

@rbeezer
Copy link
Collaborator

rbeezer commented Oct 24, 2023

Lots of complicated stuff goes into making footnotes, so I restored some "WTH" functionality.

This makes one consequential change (which sort of contradicts our discussion a few days ago).

span.ptx-footnote__contents is div.ptx-footnote__contents

This is more backward-compatible with what we have notw (such as when there is a cross-reference to a knowl, which is supported, even if a bit odd).

Maybe that means adjustments to the CSS on PreTeXtBook/CSS_core#81 has to change with an upate via a new commit.

It is easy enough to make the div a span but will be more of a change in places not directly involved in this PR (side-effects).

Beta with these changes, and items to test with PreTeXtBook/CSS_core#80:

https://pretextbook.org/beta/footnotes-20231024

I might fine-tune teh HTML PR a bit more, but this should be good for David to test, modulo div/span.

@davidfarmer - you tell me what you want for a new vwersion number (0.83?) and I'll make that change as I button this up.

@rbeezer
Copy link
Collaborator

rbeezer commented Oct 25, 2023

Two small comments:

  • My take on relevant CSS is that span -> div does not matter, other than maybe removing a display: block.
  • I have a branch ready to layer on this which will obliterate the (temporary) manufacture of cross-reference knowls for (original) footnote content.

@rbeezer
Copy link
Collaborator

rbeezer commented Nov 1, 2023

All done. I edited this pretty heavily to bring back content creation for cross-reference knowls, but silently melded into the one commit here. Sorry this one has been sort of slow-motion. But very glad to get these fake knowls out. Aah, I have another commit to get rid of that dead code!

@rbeezer rbeezer closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants