Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API support to set the language #309

Closed
ffes opened this issue Sep 21, 2022 · 5 comments
Closed

API support to set the language #309

ffes opened this issue Sep 21, 2022 · 5 comments

Comments

@ffes
Copy link

ffes commented Sep 21, 2022

There are several plugin that would like to set the spell language, for instance see this discussion in editorconfig/editorconfig#315, but I would like it to add it to https://github.com/ffes/nppfilesettings as well.

I was wondering if it would be possible add some sort of API in DSpellCheck for other plugins to change the current language used for spell checks. I know it is not possible at the moment, but having this feature to set the spell language for the docs of a project would be very useful.

I know there is NPPM_MSGTOPLUGIN, but I never used it. What I understand from the docs is that the sending plugin needs to set CommunicationInfo struct properly and send the message to the other plugin. The receiving plugin needs to handle that message in beNotified() (I think).

If this would be possible to add such an API, a second endpoint to enable or disable the spell check would be useful to have.

@Predelnik
Copy link
Owner

It should not be hard, could be implemented

@ffes
Copy link
Author

ffes commented Mar 27, 2024

Great news, thanks.

Is there an easy way to test this before it gets released?

@Predelnik
Copy link
Owner

Great news, thanks.

Is there an easy way to test this before it gets released?

Unfortunately haven't implemented artifact upload by github actions yet, will do this soon, then it would be easy.

@Predelnik
Copy link
Owner

@ffes
Copy link
Author

ffes commented Apr 7, 2024

Thanks for the download. I've tried it and it works as expected. Great!

There is just one thing I run into. I've opened #339 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants