Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker healthcheck to include result handlers #1372

Closed
cicdw opened this issue Aug 16, 2019 · 0 comments · Fixed by #1377
Closed

Update Docker healthcheck to include result handlers #1372

cicdw opened this issue Aug 16, 2019 · 0 comments · Fixed by #1377
Assignees

Comments

@cicdw
Copy link
Member

cicdw commented Aug 16, 2019

There are certain situations that we can catch prior to deployment that would result in a Flow not behaving as expected. In particular, if a user tries to deploy a Flow which:

  • has a task with retry settings
  • that task also has a keyed upstream edge
  • the upstream task has no result handler

Then retries will fail to work in Cloud. Because this situation can be inferred apriori we should raise an informative error during the Docker health check.

Similarly, if a user has tasks with checkpoint=True that don't have corresponding result handlers, we should raise an error.

Note that if the Flow itself has a result handler (but the Task does not), then all of this is OK because the Flow's should be the fallback.

@cicdw cicdw self-assigned this Aug 17, 2019
@cicdw cicdw mentioned this issue Aug 18, 2019
3 tasks
abrookins pushed a commit that referenced this issue Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant