Health checks #1377
Merged
Health checks #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrookins
pushed a commit
that referenced
this pull request
Mar 15, 2022
Move WorkQueuePausedTag next to Concurrency Limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md(if appropriate)docs/outline.tomlfor API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
This PR introduces new and improved health checks on Flows which are being built into docker storage. I also refactored this so the healthchecks live in their own file and could possibly be re-used in the future, in a non-Docker world.
Why is this PR important?
I was becoming increasingly worried that users would see cryptic result handler errors in deployment when tasks attempted retries, caching, etc. This prevents Flows with "bad" result handler configurations from being deployed to Cloud at all, pre-empting the situation to begin with and ensuring the correct behavior in deployment.
Closes #1372