Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable work stealing in Dask #1166

Merged
merged 3 commits into from
Jun 22, 2019
Merged

Disable work stealing in Dask #1166

merged 3 commits into from
Jun 22, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Jun 22, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Disable dask work stealing via env var config.

Why is this PR important?

We saw a few situations in which a task future was resolved twice; because of our version lock system the task didn't actually execute twice, but it did add some noise to the logs that we'd like to prevent.

@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

Merging #1166 into master will decrease coverage by 0.84%.
The diff coverage is n/a.

@cicdw cicdw merged commit 2fe5f3b into master Jun 22, 2019
@cicdw cicdw deleted the disable-work-stealing branch June 22, 2019 01:22
zanieb added a commit that referenced this pull request Mar 1, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants