-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto-provisioning option for Cloud Run V2 push work pools #12422
Conversation
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for the PR @discdiver! Could you give a summary of the differences between this provisioner and the existing Cloud Run provisioner? I think there might be an opportunity to share functionality between the two provisioners. |
Yeah @desertaxle, good thought. Let me see if I can DRY out the code a bit. |
Alright. Got dryer code and passing tests and I think the following is required for the V2 tests to pass, @desertaxle, but please let me know if that's incorrect.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @discdiver!
Closes #12421
Adds auto-provisioning to the one push work pool that didn't have it.
Requested by a user in Community Slack.
Example
Checklist
<link to issue>
"maintenance
,fix
,feature
,enhancement
,docs
.For documentation changes:
netlify.toml
for files that are removed or renamed.For new functions or classes in the Python SDK:
mkdocs.yml
navigation.