Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-provisioning option for Cloud Run V2 push work pools #12422

Merged
merged 11 commits into from
Mar 27, 2024
Merged

Conversation

discdiver
Copy link
Contributor

@discdiver discdiver commented Mar 25, 2024

Closes #12421

Adds auto-provisioning to the one push work pool that didn't have it.

Requested by a user in Community Slack.

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

@discdiver discdiver added the enhancement An improvement of an existing feature label Mar 25, 2024
@discdiver discdiver self-assigned this Mar 25, 2024
Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit 61fad3f
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/6603387dda87150008e1413e
😎 Deploy Preview https://deploy-preview-12422--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@discdiver discdiver marked this pull request as ready for review March 26, 2024 15:18
@discdiver discdiver requested a review from a team as a code owner March 26, 2024 15:18
@desertaxle
Copy link
Member

Thanks for the PR @discdiver! Could you give a summary of the differences between this provisioner and the existing Cloud Run provisioner? I think there might be an opportunity to share functionality between the two provisioners.

@discdiver discdiver changed the title Adds auto-provisioning option for Cloud Run V2 push work pools Add auto-provisioning option for Cloud Run V2 push work pools Mar 26, 2024
@discdiver
Copy link
Contributor Author

Yeah @desertaxle, good thought. Let me see if I can DRY out the code a bit.

@discdiver
Copy link
Contributor Author

Alright. Got dryer code and passing tests and I think the following is required for the V2 tests to pass, @desertaxle, but please let me know if that's incorrect.

I think we'll only need a test to confirm that get_infrastructure_provisioner_for_work_pool_type accepts cloud-run-v2:push as a valid type.

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @discdiver!

@discdiver discdiver merged commit a437c74 into main Mar 27, 2024
46 checks passed
@discdiver discdiver deleted the apv2 branch March 27, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add infrastructure auto-provisioning for Google Cloud Run V2 push work pools
2 participants