Remove registry conflict warning #13155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zzstoatzz
added
development
desertaxle
approved these changes
Apr 29, 2024
src/prefect/flows.py
Outdated
| for other in registry.get_instances(Flow) | ||
| if other.name == self.name and id(other.fn) != id(self.fn) | ||
| ) | ||
| and PREFECT_WARN_OBJECT_REGISTRY_CONFLICT.value() |
There was a problem hiding this comment.
nit: The .value isn't needed.
Suggested change
| and PREFECT_WARN_OBJECT_REGISTRY_CONFLICT.value() | |
| and PREFECT_WARN_OBJECT_REGISTRY_CONFLICT |
src/prefect/tasks.py
Outdated
| for other in registry.get_instances(Task) | ||
| if other.name == self.name and id(other.fn) != id(self.fn) | ||
| ) | ||
| and PREFECT_WARN_OBJECT_REGISTRY_CONFLICT.value() |
There was a problem hiding this comment.
Suggested change
| and PREFECT_WARN_OBJECT_REGISTRY_CONFLICT.value() | |
| and PREFECT_WARN_OBJECT_REGISTRY_CONFLICT |
|
why not default = True 😂 |
serinamarie
approved these changes
Apr 29, 2024
jlowin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When developing interactively or building a framework that dynamically generates tasks, my terminal is full of warnings about name conflicts in the Prefect registry. In most situations this has no consequence, but the warnings pollute my output. This introduces a setting to disable the warning, but the default is to leave it enabled (current behavior).
After talking with the team, the warning is removed entirely.