Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Artifacts documentation #13724

Merged
merged 23 commits into from
May 31, 2024

Conversation

dylanbhughes
Copy link
Contributor

@dylanbhughes dylanbhughes commented May 31, 2024

This PR updates the documentation for Artifacts with our new artifact types.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in mint.json for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in docs/mint.json navigation.

@dylanbhughes dylanbhughes changed the title Enhancment/artifacts documentation Enhancement: Artifacts documentation May 31, 2024
@dylanbhughes dylanbhughes marked this pull request as ready for review May 31, 2024 18:32
@dylanbhughes dylanbhughes requested a review from a team as a code owner May 31, 2024 18:32
Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. A few minor nits.

docs/3.0rc/concepts/artifacts.mdx Outdated Show resolved Hide resolved
docs/3.0rc/concepts/artifacts.mdx Outdated Show resolved Hide resolved
docs/3.0rc/concepts/artifacts.mdx Outdated Show resolved Hide resolved
docs/3.0rc/concepts/artifacts.mdx Outdated Show resolved Hide resolved
dylanbhughes and others added 4 commits May 31, 2024 14:58
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Copy link
Contributor

@billpalombi billpalombi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits

docs/3.0rc/concepts/artifacts.mdx Outdated Show resolved Hide resolved
docs/3.0rc/concepts/artifacts.mdx Outdated Show resolved Hide resolved
docs/3.0rc/concepts/artifacts.mdx Outdated Show resolved Hide resolved
docs/3.0rc/concepts/artifacts.mdx Outdated Show resolved Hide resolved
docs/3.0rc/concepts/artifacts.mdx Outdated Show resolved Hide resolved
docs/3.0rc/concepts/artifacts.mdx Outdated Show resolved Hide resolved
docs/3.0rc/concepts/artifacts.mdx Outdated Show resolved Hide resolved
dylanbhughes and others added 7 commits May 31, 2024 16:04
Co-authored-by: Bill Palombi <bill@prefect.io>
Co-authored-by: Bill Palombi <bill@prefect.io>
Co-authored-by: Bill Palombi <bill@prefect.io>
Co-authored-by: Bill Palombi <bill@prefect.io>
Co-authored-by: Bill Palombi <bill@prefect.io>
Co-authored-by: Bill Palombi <bill@prefect.io>
docs/3.0rc/concepts/artifacts.mdx Outdated Show resolved Hide resolved
docs/3.0rc/concepts/artifacts.mdx Outdated Show resolved Hide resolved
docs/3.0rc/concepts/artifacts.mdx Outdated Show resolved Hide resolved
@discdiver
Copy link
Contributor

Based on @WillRaphaelson 's comment elsewhere, I would mention that progress artifacts are a Cloud feature. Apologies if I missed that somewhere.

@dylanbhughes
Copy link
Contributor Author

Based on @WillRaphaelson 's comment elsewhere, I would mention that progress artifacts are a Cloud feature. Apologies if I missed that somewhere.

@discdiver that was a joke -- progress artifacts are in OSS

@discdiver
Copy link
Contributor

lol. Just saw it after the fact and thought it was strange.

@dylanbhughes dylanbhughes enabled auto-merge (squash) May 31, 2024 20:50
dylanbhughes and others added 3 commits May 31, 2024 16:50
Co-authored-by: Bill Palombi <bill@prefect.io>
Co-authored-by: Bill Palombi <bill@prefect.io>
Co-authored-by: Bill Palombi <bill@prefect.io>
Copy link
Contributor

@billpalombi billpalombi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, remaining nits

@@ -3,32 +3,30 @@ title: Artifacts
description: Prefect artifacts are persisted outputs designed for human consumption and available in the UI.
---

Artifacts are persisted outputs such as tables, Markdown, or links.
Artifacts are rich annotations on Prefect runs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Artifacts are rich annotations on Prefect runs.
Artifacts are annotations on flow and task runs.

@@ -3,32 +3,30 @@ title: Artifacts
description: Prefect artifacts are persisted outputs designed for human consumption and available in the UI.
---

Artifacts are persisted outputs such as tables, Markdown, or links.
Artifacts are rich annotations on Prefect runs.
They are visual metadata intended to be produced in flow or task runs but consumed by humans.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
They are visual metadata intended to be produced in flow or task runs but consumed by humans.
They are visual metadata intended to be produced in code but consumed by humans.

Whether you're publishing links, Markdown, or tables, artifacts provide a powerful and flexible way to showcase data within your workflows.

With artifacts, you can easily manage and share information with your team, providing valuable insights and context.
Artifacts are associated with a task run or a flow run.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Artifacts are associated with a task run or a flow run.

@dylanbhughes dylanbhughes merged commit 4983035 into main May 31, 2024
5 checks passed
@dylanbhughes dylanbhughes deleted the enhancment/artifacts-documentation branch May 31, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants