Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds warning when cache_key_fn and cache_policy are both provided to a task #14080

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Jun 17, 2024

This PR adds a warning when cache_key_fn and cache_policy are both provided to a task informing the user that cache_key_fn takes precedence.

It also adds a test recording that the cache is busted when the result_storage_key on a task changes. This will be true until we implement a transaction record store separate from result storage.

Related to #13800

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in mint.json for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in docs/mint.json navigation.

@desertaxle desertaxle added the maintenance Chores and other work not directly related to the product label Jun 17, 2024
@desertaxle desertaxle requested a review from a team as a code owner June 17, 2024 15:55
@desertaxle desertaxle requested review from cicdw and removed request for a team June 17, 2024 15:55
tests/test_tasks.py Outdated Show resolved Hide resolved
@desertaxle desertaxle merged commit fe2ba27 into main Jun 17, 2024
26 checks passed
@desertaxle desertaxle deleted the transactions-tests branch June 17, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Chores and other work not directly related to the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants