Move DeploymentImage to prefect.docker #14151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it makes sense to rename |
billpalombi
approved these changes
Jun 19, 2024
sweet, just pushed that |
desertaxle
reviewed
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #14149:
Attempting to fix a number of circular imports that block refactoring our init.py / import speed.
DeploymentImage is one such cause of circular imports (flows imports deployments import runner imports flows)
note that
prefect.deploymentsstill importsDeploymentImageso the import path is still preserved for folks who want to importfrom prefect.deployments import DeploymentImage.IMO should be called DockerImage but not trying to die on every hill