Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FlexibleScheduleType #14158

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Refactor FlexibleScheduleType #14158

merged 2 commits into from
Jun 19, 2024

Conversation

aaazzam
Copy link
Collaborator

@aaazzam aaazzam commented Jun 19, 2024

This PR is related to #14149 and #14151, refactoring problematic code locations to avoid circular import paths.

Along the way, we:

  • introduce prefect.client.types for essentially type-aliasing combinations of schemas
  • declare FlexibleScheduleTypes as a genuine type alias (so that it correctly reads the ScheduleTypes reference)
  • add a ScheduleType type-guard for better downstream typing

@aaazzam aaazzam marked this pull request as ready for review June 19, 2024 20:52
@aaazzam aaazzam requested a review from a team as a code owner June 19, 2024 20:52
@aaazzam aaazzam merged commit 11f4587 into main Jun 19, 2024
26 checks passed
@aaazzam aaazzam deleted the refactor-FlexibleScheduleList branch June 19, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakekaplan jakekaplan jakekaplan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaazzam @jakekaplan