Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed state inputs #1557

Merged
merged 6 commits into from
Sep 27, 2019
Merged

Failed state inputs #1557

merged 6 commits into from
Sep 27, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Sep 27, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR adds cached_inputs to all Failed states. When running in Cloud, Prefect will only call the input data's result handlers if all are present, otherwise it will silently pass and not persist the upstream inputs.

Why is this PR important?

This PR stores Failed state upstream inputs if possible, and passes if not. This sets the stage for manual retries in Prefect Cloud. e.g., if my task failed very unexpectedly, I might want to rerun it manually. Prior to this PR, if your task had upstream inputs that would never work. However, with this PR, as long as you set result handlers appropriately this situation will be possible with no additional configuration. cc: @jlowin

NOTE: In implementing this PR I realized that if a user in Cloud does in fact attempt to set a Task Run state that requires inputs, NoResult objects will be passed into all inputs. This can lead to surprising error messages. I attempted to raise an informative error in this situation, but it broke some of our control flow tasks so I decided to table it for now.

@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

Merging #1557 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@cicdw cicdw merged commit 14c0ad9 into master Sep 27, 2019
@cicdw cicdw deleted the failed-state-inputs branch September 27, 2019 16:08
zanieb pushed a commit that referenced this pull request Apr 13, 2022
UI: remove View Parameters & move Logs tab to be first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants