Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md
(if appropriate)docs/outline.toml
for API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
This PR adds
cached_inputs
to allFailed
states. When running in Cloud, Prefect will only call the input data's result handlers if all are present, otherwise it will silently pass and not persist the upstream inputs.Why is this PR important?
This PR stores Failed state upstream inputs if possible, and passes if not. This sets the stage for manual retries in Prefect Cloud. e.g., if my task failed very unexpectedly, I might want to rerun it manually. Prior to this PR, if your task had upstream inputs that would never work. However, with this PR, as long as you set result handlers appropriately this situation will be possible with no additional configuration. cc: @jlowin
NOTE: In implementing this PR I realized that if a user in Cloud does in fact attempt to set a Task Run state that requires inputs,
NoResult
objects will be passed into all inputs. This can lead to surprising error messages. I attempted to raise an informative error in this situation, but it broke some of our control flow tasks so I decided to table it for now.