Fix issue with merge task and comparisons #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmeek
approved these changes
Oct 9, 2019
| return self | ||
|
|
||
| def __bool__(self): | ||
| raise SyntaxError("You can't handle the truth!") |
zanieb
pushed a commit
that referenced
this pull request
Apr 13, 2022
UI: orion-design release 0.1.69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md(if appropriate)docs/outline.tomlfor API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
This PR updates the
mergetask to do anisinstancecheck instead of a direct comparison; this allows for the merge task to work with objects that don't have a robust__bool__method such as pandas dataframes and numpy arrays.Why is this PR important?
We should strive to be agnostic to what types of objects tasks return