Remove default version for Python in Docker builds #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagoodman
force-pushed
the
no-default-python
branch
from
5eac128
to
30785e8
Compare
cicdw
previously approved these changes
Nov 5, 2019
|
@wagoodman merge conflict in the changelog |
joshmeek
approved these changes
Nov 5, 2019
zanieb
pushed a commit
that referenced
this pull request
May 12, 2022
Feature: include all parent route guards when executing child route
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md(if appropriate)docs/outline.tomlfor API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
Removes the default python version from the dockerfile. This should always be explicitly provided by CircleCI (or the user for manual builds)
Why is this PR important?
This ensures the proper images are built and tagged, preventing unexpected image contents.