Add Docker daemon reconnect in the Docker agent #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagoodman
force-pushed
the
docker-agent-reconnect
branch
from
3292a30
to
56cca56
Compare
joshmeek
reviewed
Jan 15, 2020
joshmeek
reviewed
Jan 15, 2020
joshmeek
previously approved these changes
Jan 15, 2020
joshmeek
approved these changes
Jan 16, 2020
wagoodman
pushed a commit
that referenced
this pull request
Jan 16, 2020
zanieb
pushed a commit
that referenced
this pull request
Jun 7, 2022
Rename flow run alerts to flow run notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md(if appropriate)docs/outline.tomlfor API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
Modifies the docker agent to ping the docker daemon on heartbeat. After 3 failed reattempts, the agent will exit.
Closes #1916
Why is this PR important?
This will stabilize the Docker agent further when there is intermittent connections or if the Docker daemon is restarted.