Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query for state on flow run logs query for run CLI command #2192

Merged
merged 3 commits into from
Mar 25, 2020
Merged

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Mar 24, 2020

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

By querying for a flow run state in the run cloud --logs option after the initial log query it allowed for a potential condition where the state was retrieved before all of the batch logs had arrived.

Why is this PR important?

So possible tracebacks aren't missing in failed runs

cc @bnaul

@joshmeek joshmeek added the cli Related to the Prefect CLI label Mar 24, 2020
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #2192 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the Prefect CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants