Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix agent kubernetes liveness probe #2519

Merged
merged 2 commits into from
May 8, 2020
Merged

Fix agent kubernetes liveness probe #2519

merged 2 commits into from
May 8, 2020

Conversation

jcrist
Copy link

@jcrist jcrist commented May 8, 2020 •
edited
Loading

The health check server can't listen on localhost in kubernetes.

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

@jcrist
Fix agent kubernetes liveness probe
19f58bd 
The health check server can't listen on localhost in kubernetes.
cicdw
cicdw previously approved these changes May 8, 2020
View reviewed changes
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #2519 into master will not change coverage.
The diff coverage is n/a.

@cicdw cicdw merged commit 2b592af into PrefectHQ:master May 8, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdw cicdw cicdw left review comments

@jlowin jlowin Awaiting requested review from jlowin

@joshmeek joshmeek Awaiting requested review from joshmeek

@lauralorenz lauralorenz Awaiting requested review from lauralorenz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcrist @cicdw