Some cleanups to dbtshelltask #2980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauralorenz
commented
Jul 20, 2020
| @@ -86,10 +86,12 @@ def __init__( | |||
| self.dbt_kwargs = dbt_kwargs | |||
| super().__init__( | |||
| **kwargs, | |||
| command=command, | |||
There was a problem hiding this comment.
FYI command and env weren't being forwarded here and thus were overwritten to None in the super method, so they couldn't be provided at initialization
lauralorenz
commented
Jul 20, 2020
| # when set to `return_all=True`, should return a list | ||
| assert isinstance(out, list) | ||
| # check that the result is multiple lines | ||
| assert len(out) > 1 |
There was a problem hiding this comment.
FYI the output of dbt --version I am depending on looks like this:
(prefect_dev) ➜ prefect git:(cleanup-on-dbt-task-return) dbt --version
installed version: 0.17.1
latest version: 0.17.1
Up to date!
Plugins:
- bigquery: 0.17.1
- snowflake: 0.17.1
- redshift: 0.17.1
- postgres: 0.17.1
lauralorenz
changed the title
joshmeek
reviewed
Jul 20, 2020
joshmeek
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
changes/directory (if appropriate)docs/outline.tomlfor API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
First off, adds
returnthat I think just got missed in the original dbtshelltask. Otherwise the stdout from dbt being run in the shell is not retrieved as the return value of the task, against what is says in its docstrings and the intention of ShellTask itself and presumably its derivatives. This was brought up in this slack thread: https://prefect-community.slack.com/archives/CL09KU1K7/p1594912760250100While writing tests I realized that the super method was also failing to forward
commandandenvkwargs which made the@default_from_attrsfunctionality not work properly for those two, so I fixed that too.And while running tests that actually called dbt I realized that it wasn't being added as an
extrasoption in setup.py (and thus it wasn't really possible to meaningfully run the tests on CI) so I've added that as well.Why is this PR important?
So that people can use the stdout from the DbtShellTask for anything downstream.