Pass PREFECT_CORE_VERSION to Server #3651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Nov 11, 2020
| @@ -325,6 +325,9 @@ def start( | |||
| ) | |||
| env.update(PREFECT_SERVER_DB_CMD=cmd) | |||
|
|
|||
| # Pass the Core version so the Server API can return it | |||
| env.update(PREFECT_CORE_VERSION=prefect.__version__) | |||
There was a problem hiding this comment.
This could also use base_version[0] from above where base_version = prefect.__version__.split("+") or we could use default_tag which is either master if there are extra commits or core-VERSION but it seems useful to know if the prefect launching the server is dirty/has extra commits. Hmm.
There was a problem hiding this comment.
Yea I agree, I like using __version__ unprocessed 👍
cicdw
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Passes
PREFECT_CORE_VERSIONduringprefect server startfor PrefectHQ/server#126Changes
Importance
Allow core version display in the UI
Checklist
This PR:
[ ] adds new tests (if appropriate)[ ] adds a change file in thechanges/directory (if appropriate)[ ] updates docstrings for any new functions or function arguments, includingdocs/outline.tomlfor API reference docs (if appropriate)Manually verified that this value populates when running
prefect server startI do not think a changes/ entry is meaningful here.