New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add core_version
to server api query
#126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise this looks good; before we move forward with this implementation though, I want to raise a UX issue I foresee: I suspect most users use prefect server start
to stand up Server. The images that this uses are always built prior to tagging prefect
for release, meaning that if I'm on 0.13.4 of Prefect (for example), I'll see something like 0.13.3+63.g4c764ddb8
as my core_version
which I suspect will confuse people.
I'm not 100% sure how to avoid this chicken / egg problem
Could we add an env variable to the build step (something like |
I see two options:
"version": os.getenv("PREFECT_SERVER_VERSION", prefect_server.__version__),
"core_version": os.getenv("PREFECT_CORE_VERSION", prefect.__version__),
The build step for the docker image? This would still be out of date like Chris mentioned. |
I vote we take the environment variable route: "core_version": os.getenv("PREFECT_CORE_VERSION", prefect.__version__), Purely as FYI: the only thing that Server relies on from Prefect Core is serialization logic for state objects and some Flow objects, so more often than not we don't need to touch the Server images when we make core changes. Given that, I think this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really minor request to re-categorize as enhancement,
otherwise this LGTM!
Co-authored-by: Chris White <chris@prefect.io>
Note this will require a PR in |
Summary
Adds a human readable version string to the server api query indicating the Prefect Core version.
Importance
Displaying the core version the Server is using in the UI is helpful.
Gets going on #120 -- Will need UI update
Checklist
This PR:
changes/
directory (if appropriate)